browser: a11y: add column-spacing support to grid types#15374
Open
hcvcastro wants to merge 7 commits intoCollaboraOnline:distro/collabora/co-25.04from
Open
browser: a11y: add column-spacing support to grid types#15374hcvcastro wants to merge 7 commits intoCollaboraOnline:distro/collabora/co-25.04from
hcvcastro wants to merge 7 commits intoCollaboraOnline:distro/collabora/co-25.04from
Conversation
Member
hcvcastro
commented
Apr 3, 2026
hcvcastro
commented
- browser: a11y: remove tabindex attribute from row elements
- browser: a11y: remove the focusout event handler
- browser: a11y: simplify the keydown event handler
- browser: a11y: add focusin event handler
- cypress: update treelistbox focus unit test
- browser: a11y: add column-spacing support to grid types
- browser: a11y: add text-align to fixedtext type
hcvcastro
force-pushed
the
backport/distro/collabora/co-25.04/0D
branch
from
1b6e381 to
7a2427d
Compare
The default tabindex should be assigned to a unique row to receive focus. Setting it to all rows is not the default key navigation behavior. Change-Id: I3272fb485349ee4da81a46791cf08ece9150a59d Signed-off-by: Henry Castro <hcastro@collabora.com>
When the grid widget loses focus, it is not necessary to iterate through all rows or change the tabindex, since only one row is focusable. Change-Id: Ib0ecfaed5242235888441a37468f1c95f99750b6 Signed-off-by: Henry Castro <hcastro@collabora.com>
It is not necessary to create another array to find the next focusable row. We can simplify this by using the existing DOM sibling structure to navigate focus with the arrow keys. Change-Id: Ib8286560e88b8de1136f078729874b9160a41bd1 Signed-off-by: Henry Castro <hcastro@collabora.com>
When the widget receives focus from outside, it should focus the row and send a 'selection' message to the server to select the currently focused row. Change-Id: Ibcd5c1a8aa2e694cf441fa6d8f8fd7a90d637f3f Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I35cfa7a545cc5d2f8f49619e8a54341bc1f6e047 Signed-off-by: Henry Castro <hcastro@collabora.com>
The Columns dialog requires that the Spacing input labels adjust with the column-spacing property to visually center the columns and avoid misinterpretation by users with accessibility needs. Change-Id: I4ae383073a5f422e975eeb03f8ec7e044e7bbb55 Signed-off-by: Henry Castro <hcastro@collabora.com>
Some columns in the grid widget require centering the static text for accessibility. requires: https://gerrit.collaboraoffice.com/c/core/+/233 Change-Id: I439688e17b500c472d893fe97b4a5b8452e0a872 Signed-off-by: Henry Castro <henry.castro@collabora.com>
hcvcastro
force-pushed
the
backport/distro/collabora/co-25.04/0D
branch
from
7a2427d to
615e867
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.