Open
Conversation
Entries now start with tabindex="-1" instead of "0", so only one entry is in the tab order at a time. restoreInitialTabIndexes preserves tabindex="0" on the selected entry (or the first entry if none is selected) when focus leaves the tree. unselectEntry sets tabIndex to -1 instead of removing the attribute entirely. The early return in changeFocusedRow that preserved tabindex on selected entries is no longer needed since the focusout handler now restores the correct tab stop. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I7d97dcc7657fcb6586d851c9ecfa52d020ca0a22
introduces behavior for Arrow Left: When focus is on a child node that is also either an end node or a closed node, moves focus to its parent node. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I96c27c681516fbf8f6a5e7269680889b355235eb
introduces behavior for Arrow Right: When focus is on a open node, moves focus to the first child node. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I558e22b9c556a64f2a531fe3a27be5adbc5cd92e
toggleEntry and expandEntry toggle the collapsed class but did not update aria-expanded to match. Set it to true on expand and false on collapse so screen readers reflect the current state. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I892504b4651fc6e8a7562f3afb93d08fb2e560aa
Move _containerRole assignment after _isNavigator is computed so navigator treeviews get role="tree" instead of role="treegrid", which better matches its single-column, non-editable nature Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I77b96a6b91445039034b07f027ebdd37c76b1496
- Home moves focus and selection to the first visible entry - End moves focus and selection to the last visible entry Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I271153f03cd38c2c4ec02c3c74ca26c49ceb1e4c
- pressing '*' on a tree entry expands all collapsed siblings at the same level, following the standard tree keyboard pattern. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: If43ef7c0bd3fe89285da7322c61b11d61df836ff
Typing a letter jumps to the next visible entry whose text starts with that character, wrapping around from the end. Modifier keys are ignored so shortcuts are not intercepted. Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com> Change-Id: I0be6ccaf8742e47249bc3ce4c10b87c6a0a92959
caolanm
force-pushed
the
private/rparth07/treeview-navigation
branch
from
d808cd6 to
657ae7f
Compare
Contributor
|
is there overlap here with #15352 ? |
Member
It looks like a duplicated task. I haven't worked on the left and right keys yet. We should resolve this to avoid duplicating effort on the same task. |
Contributor
Author
Yes, I agree :) This PR resolves the issues mentioned in PR description. What do you suggest? |
Member
Please review my changes. I simplified and redesigned the keyboard navigation for the Arrow Up and Arrow Down keys (it's now easier to follow and read). I didn't touch the Left and Right keys for expand/collapse, as I see you already worked on that. If you agree, you can adapt your changes once this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues resolved:
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay