State fixing #273
Merged
State fixing #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Max200012
commented
May 2, 2023
Max200012
commented
- Replaced Sacramento's locator with Los Angeles' one. Los Angeles is more relevant in the 20-21th century than Sacramento
- Mildly controversial: Renamed Mongolia’s states to Western and Eastern Mongolia. Those regions are too big for them to realistically retain their administrative names
- Fixed some german and eastern european locators
- Added an economy to mukachevo
- Renamed a few hubs and states for a better historical representation
- Slight spline network adjustments
DZappala
requested changes
May 3, 2023
| HUB_NAME_STATE_LUHANSK_mine: "Oleksandrivsk" | ||
| HUB_NAME_STATE_LUHANSK_farm: "Dnipro" | ||
| HUB_NAME_STATE_LUHANSK_mine: "Voroshilovgrad" | ||
| HUB_NAME_STATE_LUHANSK_farm: "Dnipropetrovsk" |
There was a problem hiding this comment.
The goal here was to honor the correct Ukrainian names rather than their Russian counterparts. Should be Dnipro
There was a problem hiding this comment.
my reasoning was that it's the Cold War era, and that were their names during the Russian occupation, I can change them if we wanna do that
| @@ -946,8 +946,8 @@ | |||
| HUB_NAME_STATE_CRIMEA_wood: "Kerch" | |||
| HUB_NAME_STATE_LUHANSK_city: "Kharkiv" | |||
| HUB_NAME_STATE_LUHANSK_port: "Mariupol" | |||
| HUB_NAME_STATE_LUHANSK_mine: "Oleksandrivsk" | |||
| HUB_NAME_STATE_LUHANSK_farm: "Dnipro" | |||
| HUB_NAME_STATE_LUHANSK_mine: "Voroshilovgrad" | |||
There was a problem hiding this comment.
The goal here was to honor the correct Ukrainian names rather than their Russian counterparts. Should be Luhansk
|
@DZappala Fixed those two Ukrainian hub names |
DZappala
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.