-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nixos support! #805
add nixos support! #805
Conversation
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
de31697
to
8b610c9
Compare
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
raphiz/buildGradleApplication#19 is merged. This swaps back to the "original" project. Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
<components> | ||
<component group="args4j" name="args4j" version="2.33"> | ||
<artifact name="args4j-2.33.jar"> | ||
<sha256 value="91ddeaba0b24adce72291c618c00bbdce1c884755f6c4dba9c5c46e871c69ed6" origin="Generated by Gradle"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this XML blob all the hashes of the dependencies we pull in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. It's necessary for how I build using nixos currently (ref. https://github.com/raphiz/buildGradleApplication)
It can be mostly auto-generated by using gradle: ./gradlew --refresh-dependencies --write-verification-metadata sha256 build
The changes to some gradle settings I'm fine with, but there's a lot of stuff in here that I don't believe should be in this repository.
|
I can understand that decision, but due to no gradle verification metadata being present, it's almost impossible to package using nixos (you have to know & download all dependencies beforehand, as you have no internet connection when building) [I might be able to look at more of nixos and figure out what they do, but this approach works just fine for me for now]. If this repository had a gradle verification metadata setup, I might be able to package this by adding patches to move the repositories into the settings.gradle and then fetch the source & build. This would require more pr's to https://github.com/raphiz/buildGradleApplication (specifically I can't specify a source, nor patches). This has the included challenge, that the new repo has no clue when there is a new commit to dev4, making ci nearly impossible (save for polling regularly for updates).
I am unsure of how to contribute this to nixos (outside of the first point), since I am using https://github.com/raphiz/buildGradleApplication, which is not present in nixos. This is why I made a pr to here, instead of nixos. Additionally I feel that it is unfair to compare NixOs to the AUR.
The binary wrapper additionally references files, which are produced during the build.
Ultimately I made this, so I can get recaf working easily on nixos (eliminating the need to reboot into windows, make an edit, reboot into nix, try the edit, find out the edit doesn't work and repeat). |
What's new
What's fixed
Once Nixos-unstable is released as a proper release branch, we should use that.
(gradle8.8 is not in any other nixos release channel).
A new nixos release will take a bit longer, hence the decision to just use nixos-unstable.