CU-869awf45h: Update patch release script for more flexibility. #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow a minor release after a pre-release to be pushed out without any cherry-picked cahnges. Normally, with a patch release, you would expect to cherry-pick at least something, but with a pre-release that is being spun out as a full release, that's not always the case. So this PR will allow no cherry-picks only if the version being created is a minor release after a pre-release for said minor release. PS: The naming of the 2 release scripts isn't great. The prepare_patch_release.sh script is designed to deal with anything that already had a release within the same minor release cycle (i.e 2.2.1 after 2.2.0, but also 2.2.0 after 2.2.0a1 or 2.2.0rc1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow a minor release after a pre-release to be pushed out without any cherry-picked cahnges. Normally, with a patch release, you would expect to cherry-pick at least something, but with a pre-release that is being spun out as a full release, that's not always the case.
So this PR will allow no cherry-picks only if the version being created is a minor release after a pre-release for said minor release.
PS: The naming of the 2 release scripts isn't great. The prepare_patch_release.sh script is designed to deal with anything that already had a release within the same minor release cycle (i.e 2.2.1 after 2.2.0, but also 2.2.0 after 2.2.0a1 or 2.2.0rc1).