Skip to content

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Oct 13, 2025

Move to new (pydantic 2) format for model configs.

Also added a test to make sure importing these now show no warninngs.

Copy link
Collaborator

@alhendrickson alhendrickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Well, that is if the failing test isn't related ...

@mart-r
Copy link
Collaborator Author

mart-r commented Oct 14, 2025

lgtm

Well, that is if the failing test isn't related ...

Yes, it's very much related. But it should be fixed now. Just waiting for new workflows due to the other PR using up the quota.

@mart-r mart-r merged commit 03d3069 into main Oct 14, 2025
20 checks passed
@mart-r mart-r deleted the bug/medcat/move-to-new-config-for-pydantic branch October 14, 2025 14:10
tomolopolis pushed a commit that referenced this pull request Oct 15, 2025
* Update config for pydantic models - use v2-specific attribute

* Add tests to make sure importing configs procudes no errors

* Add more info to exception raised upon state clear

* Add some more information to an error

* Fix import reload during tests - run the import in a subprocess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants