Skip to content

Pushing bug fix for MetaCAT #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 30, 2025
Merged

Pushing bug fix for MetaCAT #148

merged 7 commits into from
Sep 30, 2025

Conversation

shubham-s-agarwal
Copy link
Contributor

  • Bug fix for MetaCAT through cat.get_entities()
  • Adding tests to ensure it gets caught earlier

@shubham-s-agarwal
Pushing bug fix for MetaCAT
81165ae 
- Bug fix for MetaCAT through cat.get_entities()
- Adding tests to ensure it gets caught earlier
@shubham-s-agarwal
Pushing change for metacat
34f41b2
@shubham-s-agarwal
Pushing change
bbc7f2c
@shubham-s-agarwal
Update meta_cat.py
3c08b1e
mart-r
mart-r requested changes Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@mart-r mart-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few simple things.

PS:
I'm pretty sure this is done and shouldn't be in draft. If there's a reason for it to still be in draft, ignore the review.

@shubham-s-agarwal shubham-s-agarwal marked this pull request as ready for review September 29, 2025 13:20
@shubham-s-agarwal shubham-s-agarwal self-assigned this Sep 29, 2025
@shubham-s-agarwal shubham-s-agarwal added the bug Something isn't working label Sep 29, 2025
mart-r
mart-r approved these changes Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@mart-r mart-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

tomolopolis
tomolopolis reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't an issue in medcat v2, i.e. https://github.com/CogStack/cogstack-nlp/blob/4c0495e3ac5c30d7de0e9c3b1c2c40a7419ce9fe/medcat-v2/medcat/components/addons/meta_cat/meta_cat.py ?

@shubham-s-agarwal
Copy link
Contributor Author

I've made the change now for v2 as well

@mart-r
Copy link
Collaborator

mart-r commented Sep 29, 2025

this isn't an issue in medcat v2, i.e. https://github.com/CogStack/cogstack-nlp/blob/4c0495e3ac5c30d7de0e9c3b1c2c40a7419ce9fe/medcat-v2/medcat/components/addons/meta_cat/meta_cat.py ?

I assumed I'd port the fix to v2 later on :)

I've made the change now for v2 as well

Thanks! Would be great if you could add some of the tests there as well. But I suppose we can do that later as well.

@shubham-s-agarwal
Copy link
Contributor Author

Shall I go ahead and merge?

@mart-r mart-r merged commit 764eeeb into main Sep 30, 2025
32 checks passed
@mart-r mart-r deleted the metacat_cat_update branch September 30, 2025 09:23
mart-r pushed a commit that referenced this pull request Oct 1, 2025
@shubham-s-agarwal @mart-r
Pushing bug fix for MetaCAT (#148)
99b6bee 
* Pushing bug fix for MetaCAT

- Bug fix for MetaCAT through cat.get_entities()
- Adding tests to ensure it gets caught earlier

* Pushing change for metacat

* Pushing change

* Update meta_cat.py

* Pushing update

* Update for v2

* Update meta_cat.py
@mart-r mart-r mentioned this pull request Oct 2, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomolopolis tomolopolis tomolopolis left review comments

@mart-r mart-r mart-r approved these changes

Assignees

@shubham-s-agarwal shubham-s-agarwal

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shubham-s-agarwal @mart-r @tomolopolis