fix the timex bug when may and sat appear as verbs instead of timexes #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, to avoid silly mistakes, I incorporated rules before timex chunker, so that any word matching to month names or week-of-the-day names will be forced to be a timex.
However, I realized that this rule is not accurate.
may
can be either a modal verb, or the month.sat
can be also the past tence ofsit
. So I have added a POS check now: only thosemay
's orsat
's that are NNP will be forced to be timex.sun
is a bit tricky, since the star Sun is also NNP. I pick it out of our rules and leave it up to the chunker's decision.