fix: Set keep_order arg of Search.to_queryset() to True
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default value of `keep_order` to `True` in the `Search.to_queryset` method in accordance of upstream and how it is implied in the documentation.
David-Guillot
approved these changes
Sep 20, 2022
Contributor
David-Guillot
left a comment
David-Guillot
left a comment
There was a problem hiding this comment.
If this PR needs approval, you have mine 😉 .
One thing comes to my mind: do you consider such change requires a major version? After all, it's changing the public API, and some people's code could break...
Member
Author
|
I agree, but I consider changing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default value of
keep_ordertoTruein theSearch.to_querysetmethod in accordance of upstream and how it is implied in the documentation.Fixes #27