Skip to content
This repository was archived by the owner on Nov 13, 2021. It is now read-only.

Use the System.Net.Http.HttpMethod public methods #107

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Use the System.Net.Http.HttpMethod public methods #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions maturity-level-two/tests/Codit.IntegrationTest/CarTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public CarTest()
public async Task GetCars_Ok_TestAsync()
{
//Arrange
var request = new HttpRequestMessage(new HttpMethod("GET"), "/codito/v1/car");
var request = new HttpRequestMessage(HttpMethod.Get, "/codito/v1/car");
//Act
var response = await _httpClient.SendAsync(request);
//Assert
Expand All @@ -39,7 +39,7 @@ public async Task GetSingleTeam_Ok_TestAsync()
{
//Arrange
int id = 1;
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/car/{id}");
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/car/{id}");
//Act
var response = await _httpClient.SendAsync(request);
//Arrange
Expand All @@ -51,7 +51,7 @@ public async Task GetSingleTeam_NotFound_TestAsync()
{
//Arrange
int id = -1;
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/car/{id}");
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/car/{id}");
//Act
var response = await _httpClient.SendAsync(request);
//Assert
Expand Down
58 changes: 14 additions & 44 deletions maturity-level-two/tests/Codit.IntegrationTest/CustomizationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public CustomizationTest()
public async Task GetCustomizations_Ok_TestAsync()
{
//Arrange
var request = new HttpRequestMessage(new HttpMethod("GET"), "/codito/v1/customization");
var request = new HttpRequestMessage(HttpMethod.Get, "/codito/v1/customization");
//Act
var response = await _httpClient.SendAsync(request);
//Assert
Expand All @@ -41,7 +41,7 @@ public async Task GetSingleCustomization_Ok_TestAsync()
{
//Arrange
int id = 1;
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
//Act
var response = await _httpClient.SendAsync(request);
//Assert
Expand All @@ -54,7 +54,7 @@ public async Task GetSingleCustomiation_NotFound_TestAsync()
{
//Arrange
int id = -1;
var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
//Act
var response = await _httpClient.SendAsync(request);
//Assert
Expand Down Expand Up @@ -102,7 +102,7 @@ public async Task DeleteCustomization_NoContent_TestAsync()
{
//Arrange
int id = -1;
var request = new HttpRequestMessage(new HttpMethod("DELETE"), $"/codito/v1/customization/{id}");
var request = new HttpRequestMessage(HttpMethod.Delete, $"/codito/v1/customization/{id}");
//Act
var response = await _httpClient.SendAsync(request);
//Assert
Expand All @@ -115,14 +115,14 @@ public async Task DeleteCustomization_NotFound_TestAsync()
{
//Arrange
int id = 1;
var request = new HttpRequestMessage(new HttpMethod("DELETE"), $"/codito/v1/customization/{id}");
var request = new HttpRequestMessage(HttpMethod.Delete, $"/codito/v1/customization/{id}");
//Act
var response = await _httpClient.SendAsync(request);

//Assert
response.StatusCode.Should().Be(HttpStatusCode.NoContent);

request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
response = await _httpClient.SendAsync(request);
response.StatusCode.Should().Be(HttpStatusCode.NotFound);
}
Expand All @@ -133,17 +133,17 @@ public async Task SellCustomization_Accepted_TestAsync()
//Arrange
int id = 1;

var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
var response = await _httpClient.SendAsync(request);
var actualDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());

request = new HttpRequestMessage(new HttpMethod("POST"), $"/codito/v1/customization/{id}/sale");
request = new HttpRequestMessage(HttpMethod.Post, $"/codito/v1/customization/{id}/sale");
//Act
response = await _httpClient.SendAsync(request);
//Assert
response.StatusCode.Should().Be(HttpStatusCode.Accepted);
// (Inventory must be decremented, number of sales incremented.
request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
response = await _httpClient.SendAsync(request);
var updatedDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());

Expand All @@ -157,7 +157,7 @@ public async Task SellCustomization_NotFound_TestAsync()
{
//Arrange
int id = -1;
var request = new HttpRequestMessage(new HttpMethod("POST"), $"/codito/v1/customization/{id}/sale");
var request = new HttpRequestMessage(HttpMethod.Post, $"/codito/v1/customization/{id}/sale");
//Act
var response = await _httpClient.SendAsync(request);
//Assert
Expand All @@ -182,28 +182,15 @@ public async Task SellCustomization_SoldOutBadRequest_TestAsync()
var newDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());
int id = newDto.Id;
//(Try to sell this "sold out" customization)
request = new HttpRequestMessage(new HttpMethod("POST"), $"/codito/v1/customization/{id}/sale");
request = new HttpRequestMessage(HttpMethod.Post, $"/codito/v1/customization/{id}/sale");

//Act
response = await _httpClient.SendAsync(request);

//Assert
response.StatusCode.Should().Be(HttpStatusCode.BadRequest);

}

//[Fact]
//public async Task VoteAsBestPlayer_NotFound_TestAsync()
//{
// //Arrange
// int playerId = -1;
// var request = new HttpRequestMessage(new HttpMethod("POST"), $"/world-cup/v1/players/{playerId}/vote");
// //Act
// var response = await _httpClient.SendAsync(request);
// //Assert
// response.StatusCode.Should().Be(HttpStatusCode.NotFound);
//}

[Fact]
public async Task UpdateCustomizationIncremental_NotFound_TestAsync()
{
Expand All @@ -214,7 +201,6 @@ public async Task UpdateCustomizationIncremental_NotFound_TestAsync()
InventoryLevel = 100
};


var request = TestExtensions.GetJsonRequest(customization, "PATCH", $"/codito/v1/customization/{id}");

// Act
Expand All @@ -234,7 +220,7 @@ public async Task UpdateCustomizationIncremental_NoContent_TestAsync()
InventoryLevel = 100
};

var request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
var request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
var response = await _httpClient.SendAsync(request);
var actualDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());
request = TestExtensions.GetJsonRequest(customization, "PATCH", $"/codito/v1/customization/{id}");
Expand All @@ -246,7 +232,7 @@ public async Task UpdateCustomizationIncremental_NoContent_TestAsync()

//Assert
response.StatusCode.Should().Be(HttpStatusCode.NoContent);
request = new HttpRequestMessage(new HttpMethod("GET"), $"/codito/v1/customization/{id}");
request = new HttpRequestMessage(HttpMethod.Get, $"/codito/v1/customization/{id}");
response = await _httpClient.SendAsync(request);
var updatedDto = JsonConvert.DeserializeObject<CustomizationDto>(await response.Content.ReadAsStringAsync());
updatedDto.Id.Should().Be(actualDto.Id);
Expand All @@ -259,22 +245,6 @@ public async Task UpdateCustomizationIncremental_NoContent_TestAsync()
// this one is updated
updatedDto.InventoryLevel.Should().Be(customization.InventoryLevel);
updatedDto.InventoryLevel.Should().NotBe(actualDto.InventoryLevel);


}



//[Fact]
//public async Task DeletePlayer_NotFound_TestAsync()
//{
// //Arrange
// int playerId = 1;
// var request = new HttpRequestMessage(new HttpMethod("DELETE"), $"/world-cup/v1/players/{playerId}");
// //Act
// var response = await _httpClient.SendAsync(request);
// //Assert
// response.StatusCode.Should().Be(HttpStatusCode.NotFound);
//}
}
}
2 changes: 1 addition & 1 deletion maturity-level-two/tests/Codit.UnitTest/Controllers/carControllerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public CarControllerTest()
public async Task GetCars_test()
{
//act
var cars = (await _controller.GetCars()) as OkObjectResult;
var cars = (await _controller.GetCars(null)) as OkObjectResult;

//assert
Assert.NotNull(cars);
Expand Down