support authentication for zookeeper/etcd #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fancy-rabbit Thank you very much for your contribution. I'll review and test this PR later !! |
|
I would like to ask for a long time to issue a version that supports zookeeper auth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR add support for authentication of zookeeper/etcd.
when coordinator=filesystem, authentication is skipped.
when coordinator=zookeeper, the client will addauth after connected, and replace the worldACL with the corresponding digestACL.
when coordinator=etcd, the client will authenticate with the specified username/password, permissions should be granted manually with etcdctl.
but i'm not familiar with etcd, thus the etcd part is not well-tested.
please review it.
thanks very much.