fix(config): make DefaultPaths() thread-safe with sync.Once#98
Merged
CalvinAllen merged 2 commits intomainfrom Dec 11, 2025
Merged
fix(config): make DefaultPaths() thread-safe with sync.Once#98CalvinAllen merged 2 commits intomainfrom
CalvinAllen merged 2 commits intomainfrom
Conversation
- Use sync.Once to ensure paths are initialized exactly once - Eliminates race condition when called from multiple goroutines - Add concurrent access test with 100 goroutines - Add resetPathsForTesting() helper for test isolation Closes #94
Add dedicated race detection job that runs Go tests with -race flag on Linux (requires cgo). This validates thread-safety of concurrent code like the sync.Once pattern used in DefaultPaths(). - Runs on ubuntu-latest where cgo is available - Generates GitHub Actions summary with race detection results - Build jobs now depend on race detection passing - Extracts and displays race details if any are found 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.Onceto ensure paths are initialized exactly onceos.UserHomeDir()andfilepath.Join()are called only onceChanges
src/internal/config/paths.go
sync.Oncefor thread-safe initializationDefaultPaths()now usespathsOnce.Do()instead of nil checksrc/internal/config/paths_test.go
resetPathsForTesting()helper to reset singleton for test isolationTestDefaultPaths_ConcurrentAccesstest with 100 goroutinesTest plan
Closes #94