fix(path): respect XDG_DATA_HOME on macOS and Windows#222
Merged
CalvinAllen merged 1 commit intomainfrom Feb 9, 2026
Merged
Conversation
ShimsDir(), install.sh, and install.ps1 were not checking XDG_DATA_HOME on macOS/Windows, causing dtvem init to add wrong paths to PATH when XDG_DATA_HOME was set. This brings all three locations in sync with the canonical getRootDir() logic in config/paths.go. Closes #202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShimsDir()inpath/path.go,get_dtvem_root()ininstall.sh, andGet-DtvemRootininstall.ps1were not checkingXDG_DATA_HOMEon macOS/Windows, causingdtvem initto add wrong paths (~/.dtvem/binand~/.dtvem/shims) to PATH whenXDG_DATA_HOMEwas setXDG_DATA_HOMEopt-in checks to all three locations, bringing them in sync with the canonicalgetRootDir()logic inconfig/paths.goShimsDir()covering DTVEM_ROOT override, XDG on non-Linux, no-XDG fallback, and DTVEM_ROOT-over-XDG precedenceCloses #202
Test plan
go vet ./...passesgo test ./...passes (including new ShimsDir XDG tests)golangci-lint run ./...reports 0 issues