fix(ci): select all versions in nvm migration test#148
Merged
CalvinAllen merged 1 commit intomainfrom Dec 14, 2025
Merged
Conversation
The nvm migration test was selecting option "1" which picked up the pre-installed system Node.js instead of the nvm-installed version. Change to "all" so both system and nvm versions get migrated, then verify that the nvm version (20.18.0) is among the migrated versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the nvm migration test that was failing because it selected the wrong version.
Problem:
[1] systemand[2] nvm1\n...selected the system version, not the nvm versionSolution:
1toallto migrate both versionsTest plan
migrate-node-ubuntu-nvmworkflow passes