fix(lint): extract pathActionMove constant to fix goconst warning#117
Merged
CalvinAllen merged 2 commits intomainfrom Dec 12, 2025
Merged
fix(lint): extract pathActionMove constant to fix goconst warning#117CalvinAllen merged 2 commits intomainfrom
CalvinAllen merged 2 commits intomainfrom
Conversation
The string "move" appeared 3 times in path_windows.go, which triggered the goconst linter. Extract to a constant for consistency. Fixes #114
Run golangci-lint with GOOS set to linux, darwin, and windows to catch platform-specific lint issues in files with build tags (e.g., goconst warning in path_windows.go that was only visible on Windows).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"move"to a constantpathActionMoveinpath_windows.go//go:build windowstag)Test plan
npm run checkFixes #114