-
Notifications
You must be signed in to change notification settings - Fork 43
Add Closest Operation #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass tests. - Sorry for the mess, IDK what git's on about.
- Replace shrinking jump with marching low and high limits.
Merging! |
I was working on more optimizations of this because I started working with a huge dataset. It might make sense to wait for the save-load PR so I can contribute that data tree as well. |
(invite sent btw!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finds a specified number of points closest to a given point.
Uses a sort of binary search with the radius of a Circle query. Using Rectangle may be more performant for finding a single closest point but produces inaccurate results for operations expecting multiple detected points.
For the handling of ties, I specified a limit on the number of checks and return a slice of the current query if we reach it.