Skip to content

Adding basic Processing version of the JS QuadTree #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adding basic Processing version of the JS QuadTree #16

wants to merge 1 commit into from

Conversation

Carla-de-Beer
Copy link
Contributor

@Carla-de-Beer Carla-de-Beer commented Mar 31, 2018

*version

Copy link
Contributor

@Dezzles Dezzles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's now a Circle object in the JS QuadTree implementation, so a basic Interface might be needed to handle both Rectangle and Circle

return false;
}

ArrayList<Point> query(Rectangle range, ArrayList<Point> found) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be List rather than ArrayList?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ArrayList is good b/c it's what I use as standard catch-all flexible array in my tutorials and examples!

@shiffman
Copy link
Member

I wonder if this might make more sense as a separate repo? Rather than have both in this repo?

@shiffman shiffman changed the title Adding basic Processing evasion of the JS QuadTree Adding basic Processing version of the JS QuadTree Mar 31, 2018
@WakeMeAtThree
Copy link

@shiffman I think making it part of a separate repo would work better, so that this repo keeps focus on it being JS library. We can then port examples to java as well to match the examples here. On the other hand, you did mention in a previous livestream that you were interested in creating some sort of processing library on eclipse CC. Can both things happen concurrently?

@shiffman
Copy link
Member

Hi! I'm revisiting the QuadTree stuff as I'm teaching it in my class next week. @Carla-de-Beer would you mind posting this code in your own repo and then adding a link to it from the README here?

@Carla-de-Beer
Copy link
Contributor Author

Of course, yes. You are correct, it makes more sense to keep the P5,js repository clean. I added a new pull request (Update README.md #35) to allow for this. Apologies if I caused any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants