isURL - email addresses validate as URLs validatorjs#707

CodingNagger · Oct 2, 2018 · 87b43c5 · 87b43c5
1 parent 5d3fac0
commit 87b43c5
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 1 deletion.
diff --git a/lib/isURL.js b/lib/isURL.js
@@ -103,6 +103,9 @@ function isURL(url, options) {
 
   split = url.split('@');
   if (split.length > 1) {
+    if (options.exclude_auth_url) {
+      return false;
+    }
     auth = split.shift();
     if (auth.indexOf(':') >= 0 && auth.split(':').length > 2) {
       return false;

diff --git a/src/lib/isURL.js b/src/lib/isURL.js
@@ -77,6 +77,9 @@ export default function isURL(url, options) {
 
   split = url.split('@');
   if (split.length > 1) {
+    if (options.exclude_auth_url) {
+      return false;
+    }
     auth = split.shift();
     if (auth.indexOf(':') >= 0 && auth.split(':').length > 2) {
       return false;

diff --git a/test/validators.js b/test/validators.js
@@ -578,6 +578,20 @@ describe('Validators', () => {
     });
   });
 
+  it('should allow rejecting urls containing authentication information', () => {
+    test({
+      validator: 'isURL',
+      args: [{ exclude_auth_url: true }],
+      valid: [
+        'doe.com',
+      ],
+      invalid: [
+        'john@doe.com',
+        'john:john@doe.com',
+      ],
+    });
+  });
+
   it('should validate MAC addresses', () => {
     test({
       validator: 'isMACAddress',

diff --git a/validator.js b/validator.js
@@ -434,6 +434,9 @@ function isURL(url, options) {
 
   split = url.split('@');
   if (split.length > 1) {
+    if (options.exclude_auth_url) {
+      return false;
+    }
     auth = split.shift();
     if (auth.indexOf(':') >= 0 && auth.split(':').length > 2) {
       return false;

diff --git a/validator.min.js b/validator.min.js