Skip to content

feat: Simplify configuration of delay between retries #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jonasschaude
Copy link
Contributor

This PR adds the possibility to configure a delay between retries. Sometimes it is helpful to have a "cool down" phase between multiple requests. This could for example also differ between the first and the second retry attempt as shown in example/lib/weather_app.dart.

@jonasschaude
Copy link
Contributor Author

Any updates on this PR? Do I have to further adapt something or could this be integrated? 😉

@CodingAleCR
Copy link
Owner

hi, @jonasschaude this is failing the CI for some reason, I'll check it out and get back to you, in case there's anything that needs fixing.

@CodingAleCR
Copy link
Owner

I am confirming that the failed checks are because of the pipeline and not your code. I'll fix this and hopefully release soon.

@CodingAleCR CodingAleCR self-requested a review May 27, 2023 00:30
Copy link
Owner

@CodingAleCR CodingAleCR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonasschaude this looks great. Could you please update the README to reflect the added features?

@CodingAleCR
Copy link
Owner

Hi @jonasschaude are you able to update the README?

@jonasschaude
Copy link
Contributor Author

Hi @jonasschaude are you able to update the README?

Hey @CodingAleCR thanks a lot for reviewing the PR. I managed in the meantime to update the README file. Would be happy if you could double check the changes once again and let me know if there is more that needs to be adapted. Thanks in advance.

@jonasschaude jonasschaude requested a review from CodingAleCR June 20, 2023 20:11
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 29.09%. Comparing base (5c10e33) to head (dc20147).
Report is 15 commits behind head on main.

Files Patch % Lines
lib/http/intercepted_client.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   29.28%   29.09%   -0.20%     
==========================================
  Files          17       17              
  Lines         239      244       +5     
==========================================
+ Hits           70       71       +1     
- Misses        169      173       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasschaude
Copy link
Contributor Author

@CodingAleCR do you have any update on this? ;)

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 17, 2024
@CodingAleCR CodingAleCR merged commit cd58d44 into CodingAleCR:main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants