-
-
Notifications
You must be signed in to change notification settings - Fork 70
feat: Simplify configuration of delay between retries #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simplify configuration of delay between retries #122
Conversation
Any updates on this PR? Do I have to further adapt something or could this be integrated? 😉 |
hi, @jonasschaude this is failing the CI for some reason, I'll check it out and get back to you, in case there's anything that needs fixing. |
I am confirming that the failed checks are because of the pipeline and not your code. I'll fix this and hopefully release soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonasschaude this looks great. Could you please update the README to reflect the added features?
Hi @jonasschaude are you able to update the README? |
…ries to readme file
Hey @CodingAleCR thanks a lot for reviewing the PR. I managed in the meantime to update the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 29.28% 29.09% -0.20%
==========================================
Files 17 17
Lines 239 244 +5
==========================================
+ Hits 70 71 +1
- Misses 169 173 +4 ☔ View full report in Codecov by Sentry. |
@CodingAleCR do you have any update on this? ;) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR adds the possibility to configure a delay between retries. Sometimes it is helpful to have a "cool down" phase between multiple requests. This could for example also differ between the first and the second retry attempt as shown in
example/lib/weather_app.dart
.