Solved various #warning TODO lines throughout the codebase.

Added loopback network server to intel/pc configuration.

config/intel/pc/init.sh

@@ -12,6 +12,7 @@ stdio /console/tty0 /console/tty0
 #
 /server/time/server &
 /server/filesystem/tmp/server /tmp &
+/server/network/loopback/server &
 
 #
 # Serial console

lib/liballoc/SplitAllocator.cpp

@@ -62,7 +62,6 @@ Allocator::Result SplitAllocator::allocate(Address addr)
 
 Allocator::Result SplitAllocator::allocateLow(Size size, Address *addr, Size align)
 {
-#warning Size parameter should return the actual size on output too. Like the default allocate()
     return m_alloc->allocate(&size, addr, align, 0);
 }
 

lib/liballoc/SplitAllocator.h

@@ -84,8 +84,7 @@ class SplitAllocator : public Allocator
     /**
      * Allocate from lower memory.
      *
-     * @param size Amount of memory in bytes to allocate on input. 
-     *             On output, the amount of memory in bytes actually allocated.
+     * @param size Amount of memory in bytes to allocate.
      * @param addr Output parameter which contains the address
      *             allocated on success.
      * @param align Alignment of the required memory or use ZERO for default.
@@ -96,8 +95,7 @@ class SplitAllocator : public Allocator
     /**
      * Allocate from high memory.
      *
-     * @param size Amount of memory in bytes to allocate on input. 
-     *             On output, the amount of memory in bytes actually allocated.
+     * @param size Amount of memory in bytes to allocate.
      * @param addr Output parameter which contains the address
      *             allocated on success.
      * @param align Alignment of the required memory or use ZERO for default.

lib/libarch/MemoryContext.cpp

@@ -40,7 +40,6 @@ MemoryContext::Result MemoryContext::mapRange(Memory::Range *range)
 {
     Result r = Success;
 
-#warning should make the allocation responsibility by the caller?
     // Allocate physical pages, if needed.
     if (!range->phys)
         m_alloc->allocate(&range->size, &range->phys);
@@ -65,7 +64,6 @@ MemoryContext::Result MemoryContext::mapRegion(MemoryMap::Region region,
                                                Size size,
                                                Memory::Access access)
 {
-#warning Unused function!
     Memory::Range range;
     Result r;
 
@@ -129,7 +127,7 @@ MemoryContext::Result MemoryContext::findFree(Size size, MemoryMap::Region regio
     Memory::Range r = m_map->range(region);
     Size currentSize = 0;
     Address addr = r.virt, currentAddr = r.virt, tmp;
-    
+
     while (addr < r.virt+r.size && currentSize < size)
     {
         // TODO: check for success instead. error codes may change.

lib/libarch/intel/IntelAPIC.cpp

@@ -189,6 +189,7 @@ IntController::Result IntelAPIC::sendStartupIPI(uint cpuId, Address addr)
         m_io.write(IntCommand1, cfg);
 
         // Wait 1 milisecond
+#warning FIX this.
         // TODO: this is difficult in the current implementation, because
         //       the *userspace* instance of this class does not have
         //       m_frequency set.. better solution is that libarch provides a Timer

lib/libfs/DeviceServer.cpp

@@ -70,7 +70,6 @@ void DeviceServer::registerInterrupt(Device *dev, Size vector)
 void DeviceServer::interruptHandler(Size vector)
 {
     List<Device *> *lst = m_interrupts.at(vector);
-    Error ret;
 
     // Do we have any Devices with this interrupt vector?
     if (lst)

lib/libmpi/MPI.cpp

@@ -122,7 +122,7 @@ int MPI_Init(int *argc, char ***argv)
             snprintf(cmd, 512, "%s -a %x -c %d",
                      programPath, memChannelBase.phys, coreCount);
 
-            for (Size j = 1; j < *argc; j++)
+            for (int j = 1; j < *argc; j++)
             {
                 strcat(cmd, " ");
                 strcat(cmd, (*argv)[j]);

lib/libnet/Ethernet.cpp

@@ -115,7 +115,7 @@ Error Ethernet::process(NetworkQueue::Packet *pkt, Size offset)
                 return m_ipv4->process(pkt, offset + sizeof(Ethernet::Header));
 
         default:
-            DEBUG("dropped unknown ethernet type: " << (void *) ether->type);
+            DEBUG("dropped unknown ethernet type: " << (int) ether->type);
             break;
     }
     return EINVAL;

lib/libnet/ICMP.cpp

@@ -107,7 +107,6 @@ Error ICMP::sendPacket(IPV4::Address ip, ICMP::Header *header)
 {
     DEBUG("");
 
-    Ethernet::Address ethAddr;
     NetworkQueue::Packet *pkt;
     Error r;
 

lib/libnet/IPV4.cpp

@@ -141,7 +141,7 @@ Error IPV4::getTransmitPacket(NetworkQueue::Packet **pkt,
     hdr->versionIHL     = (sizeof(Header) / sizeof(u32)) | (4 << 4);
     hdr->typeOfService  = 0;
     hdr->length         = cpu_to_be16(size + sizeof(Header));
-    hdr->identification = cpu_to_be16(m_id++);
+    hdr->identification = cpu_to_be16(m_id);
     hdr->fragmentOffset = cpu_to_be16(0x4000); // dont fragment flag
     hdr->timeToLive     = 64;
     hdr->protocol       = type;
@@ -150,6 +150,7 @@ Error IPV4::getTransmitPacket(NetworkQueue::Packet **pkt,
     hdr->checksum       = 0;
     hdr->checksum       = checksum(hdr, sizeof(Header));
     (*pkt)->size += sizeof(Header);
+    m_id++;
 
     // Success
     return ESUCCESS;

lib/libposix/Runtime.cpp

@@ -142,6 +142,8 @@ void setupRandomizer()
 void setupChannels()
 {
     ChannelClient *client = new ChannelClient();
+    (void) client;
+
     ChannelClient::instance->setRegistry(new ChannelRegistry());
 }
 

lib/libposix/unistd/forkexec.cpp

@@ -78,7 +78,7 @@ int forkexec(const char *path, const char *argv[])
     // this process can read the libexec data once, and then let coreserver create a process for it.
 
     // Map program regions into virtual memory of the new process
-    for (int i = 0; i < numRegions; i++)
+    for (Size i = 0; i < numRegions; i++)
     {
         // Copy executable memory from this region
         range.virt   = regions[i].virt;

lib/libposix/unistd/spawn.cpp

@@ -55,7 +55,7 @@ int spawn(Address program, Size programSize, const char *command)
     // this process can read the libexec data once, and then let coreserver create a process for it.
 
     // Map program regions into virtual memory of the new process
-    for (int i = 0; i < numRegions; i++)
+    for (Size i = 0; i < numRegions; i++)
     {
         // Copy executable memory from this region
         range.virt   = regions[i].virt;

lib/libstd/ArgumentParser.cpp

@@ -101,7 +101,12 @@ ArgumentParser::Result ArgumentParser::registerPositional(const char *name,
                                                           const char *description,
                                                           Size count)
 {
-#warning TODO: check that only the last positional can have count==0
+    // Check that only the last positional can have count zero.
+    if (m_positionals.count() &&
+        m_positionals.at(m_positionals.count() - 1)->getCount() == 0)
+    {
+        return AlreadyExists;
+    }
     Argument *arg = new Argument(name);
     arg->setDescription(description);
     arg->setCount(count);

lib/libstd/ArgumentParser.h

@@ -41,7 +41,8 @@ class ArgumentParser
     {
         Success,
         InvalidArgument,
-        NotFound
+        NotFound,
+        AlreadyExists
     };
 
     /**

lib/libusb/SConscript

@@ -18,8 +18,6 @@
 Import('build_env')
 
 env = build_env.Clone()
-
-if env['ARCH'] == 'arm':
-    env.UseLibraries(['libstd', 'libarch', 'libfs', 'libipc', 'libposix'])
-    env.UseServers([])
-    env.TargetLibrary('libusb', [ Glob('*.cpp') ])
+env.UseLibraries(['libstd', 'libarch', 'libfs', 'libipc', 'libposix'])
+env.UseServers([])
+env.TargetLibrary('libusb', [ Glob('*.cpp') ])

server/network/loopback/SConscript

@@ -21,6 +21,4 @@ env = build_env.Clone()
 env.UseServers(['log', 'filesystem', 'core'])
 env.UseLibraries([ 'libposix', 'liballoc', 'libstd', 'libarch',
                    'libexec', 'libipc', 'libfs', 'libusb', 'libnet' ])
-
-if env['ARCH'] == 'arm':
-    env.TargetProgram('server', [ Glob('*.cpp') ])
+env.TargetProgram('server', [ Glob('*.cpp') ])