Skip to content

Fix space character incorrectly added to the start of every paragraph.#118

Merged
stesee merged 4 commits intoCodeuctivity:mainfrom
huan086:fix/space-added-to-every-paragraph-start
Feb 14, 2025
Merged

Fix space character incorrectly added to the start of every paragraph.#118
stesee merged 4 commits intoCodeuctivity:mainfrom
huan086:fix/space-added-to-every-paragraph-start

Conversation

@huan086
Copy link

@huan086 huan086 commented Feb 12, 2025

For example in HC007-Test-02

Word document

HC007-Test-02 docx

Before this fix

HC007-Test-02 docxExpectation

After this fix

HC007-Test-02 docxExpectation

@huan086 huan086 requested a review from stesee as a code owner February 12, 2025 07:50
@huan086 huan086 marked this pull request as draft February 12, 2025 13:35
@huan086 huan086 force-pushed the fix/space-added-to-every-paragraph-start branch from b82fdd7 to 8f7d172 Compare February 12, 2025 13:39
@huan086 huan086 marked this pull request as ready for review February 12, 2025 13:40
@huan086
Copy link
Author

huan086 commented Feb 12, 2025

Previous test failed because I've missed regenerating some images. All tests passed on my machine now.

Test summary: total: 732, failed: 0, succeeded: 731, skipped: 1, duration: 101.9s
Build succeeded with 3195 warning(s) in 127.5s

@huan086 huan086 marked this pull request as draft February 12, 2025 13:46
@huan086 huan086 force-pushed the fix/space-added-to-every-paragraph-start branch from 8f7d172 to 4c50ec3 Compare February 12, 2025 13:54
@huan086 huan086 marked this pull request as ready for review February 12, 2025 13:54
@huan086
Copy link
Author

huan086 commented Feb 13, 2025

Any idea what's causing HC007-Test-02 and HC010-Test-05 to fail?

I'm suspecting that the test server doesn't have the Century Gothic font, which are used in HC007-Test-02 and HC011-Test-06. The passing doc that uses Century Gothic has a large pixel noise value [InlineData("HC011-Test-06.docx", 80000, false)]

Garamond is used in HC010-Test-05 and HC011-Test-06. HC011-Test-06 is the same one as above with the large pixel noise.

Shall I change the 3 Word documents to use fonts that are known to work?

@stesee
Copy link
Collaborator

stesee commented Feb 14, 2025

Any idea what's causing HC007-Test-02 and HC010-Test-05 to fail?

I'm suspecting that the test server doesn't have the Century Gothic font, which are used in HC007-Test-02 and HC011-Test-06. The passing doc that uses Century Gothic has a large pixel noise value [InlineData("HC011-Test-06.docx", 80000, false)]

Garamond is used in HC010-Test-05 and HC011-Test-06. HC011-Test-06 is the same one as above with the large pixel noise.

Shall I change the 3 Word documents to use fonts that are known to work?

You're right—the failures are likely due to the missing Century Gothic and Garamond fonts on the test server.
We should relax the expectation here.

@stesee stesee merged commit f733afa into Codeuctivity:main Feb 14, 2025
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
@huan086 huan086 deleted the fix/space-added-to-every-paragraph-start branch February 14, 2025 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants