Requirement to see the differences between two images when a mask is used.

[MJB222398]

For my application I am comparing two images using a mask image (ImageSharpCompare.CalcDiff) so that I can ignore differences between the two images in certain areas. In the case where a difference is found I want to be able to visualise that difference as it will be quite subtle and hard to spot without assistance. To do this the only method available is ImageSharpCompare.CalcDiffMaskImage but I cannot supply a mask to this. So what I get is an image representing the diff of the two images but it includes the areas that I expect to be different (the ones the mask would hide) and so it is difficult for me to see what the difference I did not expect actually is.

I would like to be able to supply a filepath for an image mask when using the ImageSharpCompare.CalcDiffMaskImage method.

[stesee]

That's something we should add. I think an overload of ImageSharpCompare.CalcDiffMaskImage with an additional parameter that takes an existing mask should cover this. What do you think?

[MJB222398]

Yes thats what I was envisioning. Hopefully a simple change and I imagine very useful for others too. We would need this for all the different methods that take the stream, filepath, image etc.

[MJB222398]

@stesee do you allow pull requests? I wanted to make one - on the Pull Requests tab I can see it says:

First time contributing to Codeuctivity/ImageSharp.Compare?
If you know how to fix an issue, consider opening a pull request for it.

But if I try to push to a new branch it says permission denied.

[stesee]

Sure, that would be great.

[MJB222398]

Nice, but as I said above, its not possible I think. I appear not to have permission? Unless there is some issue at my end with my auth, though I can push to other repos without issue.

[stesee]

The common process for 1st time contributors is:

• Create a fork
• Change things in the fork
• Create a PR to the upstream project

[MJB222398]

@stesee I have created a PR for this, please let me know what you think

[stesee]

good work. Please take a look at the review finding... public methods that were added should all have a test.

[MJB222398]

@stesee should be all done now

[MJB222398]

This feature has now been implemented and this ticket can be closed. @stesee would I now be able to raise PRs directly within this repository now or do I continue working from my Fork?