Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

tomaszdworniczak
Copy link
Contributor

@tomaszdworniczak tomaszdworniczak commented Oct 16, 2021

Closes #230

@vercel
Copy link

vercel bot commented Oct 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-website – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/HV39JjFFHsQKodJixozPmwanwtFw
✅ Preview: https://coderscamp-website-git-issue-230-writelearnin-47a39d-coderscamp.vercel.app

coderscamp-storybook – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/8gMzubukKkSjqNnqZB88qxfyWPaU
✅ Preview: https://coderscamp-storybook-git-issue-230-writelearn-5e9630-coderscamp.vercel.app

coderscamp-docs – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/74yLqx6m5hMLeKAZaBPc8amnqYNb
✅ Preview: https://coderscamp-docs-git-issue-230-writelearningma-137c14-coderscamp.vercel.app

@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-230--w-qj2srh October 16, 2021 19:56 Inactive
@tomaszdworniczak tomaszdworniczak changed the title Issue 230 write learning materials tasks create slice uncomplete task task was uncompleted feat: Create slice UncompleteTask -> TaskWasUncompleted Oct 16, 2021
@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-230--w-qj2srh October 16, 2021 20:12 Inactive
@tomaszdworniczak tomaszdworniczak changed the title feat: Create slice UncompleteTask -> TaskWasUncompleted feat: Create slice UncompleteTask TaskWasUncompleted Oct 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2021

Codecov Report

Merging #395 (afe0aac) into main (b21f090) will increase coverage by 2.36%.
The diff coverage is 89.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   88.01%   90.38%   +2.36%     
==========================================
  Files         148      155       +7     
  Lines        1661     1903     +242     
  Branches      213      254      +41     
==========================================
+ Hits         1462     1720     +258     
+ Misses        198      182      -16     
  Partials        1        1              
Flag Coverage Δ
api 88.69% <89.18%> (+3.14%) ⬆️
ui 98.48% <ø> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...entation/rest/process-st-events.rest-controller.ts 68.75% <33.33%> (-8.18%) ⬇️
...learning-materials-tasks/domain/uncomplete-task.ts 87.50% <87.50%> (ø)
...ed/commands/uncomplete-task.application-command.ts 100.00% <100.00%> (ø)
...tasks/application/complete-task.command-handler.ts 100.00% <100.00%> (ø)
...sks/application/uncomplete-task.command-handler.ts 100.00% <100.00%> (ø)
...e/learning-materials-tasks/domain/complete-task.ts 87.50% <100.00%> (+1.78%) ⬆️
...als-tasks/learning-materials-tasks.write-module.ts 100.00% <100.00%> (ø)
...on/application/user-registration-emails.service.ts 75.00% <0.00%> (-25.00%) ⬇️
...th/automation/user-registration-started.handler.ts 68.75% <0.00%> (-18.75%) ⬇️
...ation/application/register-user.command-handler.ts 96.00% <0.00%> (-4.00%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21f090...afe0aac. Read the comment docs.

@MateuszNaKodach MateuszNaKodach changed the title feat: Create slice UncompleteTask TaskWasUncompleted feat: create slice UncompleteTask TaskWasUncompleted Oct 22, 2021
@MateuszNaKodach MateuszNaKodach changed the title feat: create slice UncompleteTask TaskWasUncompleted feat: create slice UncompleteTask -> TaskWasUncompleted (#230) Oct 22, 2021
@MateuszNaKodach MateuszNaKodach changed the title feat: create slice UncompleteTask -> TaskWasUncompleted (#230) feat(api): create slice UncompleteTask -> TaskWasUncompleted (#230) Oct 22, 2021
Copy link
Member

@MateuszNaKodach MateuszNaKodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job @tomaszdworniczak !
Have you learned something during this task :) ?

Changes:
I've just: add type LearningMaterialsTasksDomainEvent = TaskWasCompleted | TaskWasUncompleted and run lint:fix :)

@MateuszNaKodach MateuszNaKodach merged commit 9e1015a into main Oct 22, 2021
@MateuszNaKodach MateuszNaKodach deleted the issue-230-_Write_LearningMaterialsTasks_Create_slice_UncompleteTask_TaskWasUncompleted branch October 22, 2021 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Write | LearningMaterialsTasks] Create slice UncompleteTask -> TaskWasUncompleted
4 participants