Backend test - Junior Barros #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dbtest and application
|
Describe: I used the technologies mentioned in the documentation because of their ease and productivity. Nestjs with prism and typescript allow to modularize the files very well and separate the obligations of each module. Although prism is a "recent" ORM, it is very useful and easy to use, I preferred to use it in this application due to the simplicity of the test. Unfortunately, testing with the prism is not my strong point, I've done TDD with typeORM and with mongoose, but never with the prism, which left me a little confused about its development. There are several points that can be improved, tweaks to the code to become cleaner, and other situations, but I tried to do the best possible given my available time and knowledge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The essentials are ready, there are still a few corrections left, adjustments to the clean code, clearer documentation, validations regarding the monthly investment gain and the example code for sending emails and implementing unit tests.