Skip to content

Conversation

@Nkarnaud
Copy link

the login is build on the django auth module. the signup is build using the userCreationForm

to run the app user:
python manager runserver
this link will bring you to the home page:
http://127.0.0.1:8000/ from this home page you have a link to signup and login.

@Nkarnaud Nkarnaud closed this Apr 24, 2019
@Nkarnaud Nkarnaud reopened this Apr 24, 2019
@KenanBek
Copy link
Member

In general, it looks quite OK, especially for learning purposes.

BUT

For the further learning purposes, try to add the following items:

  • flake8 for linting
  • isort for sorting
  • view tests for new views

@KenanBek
Copy link
Member

Before commiting new messages, use linter and isort to check your part of source code.

@Nkarnaud
Copy link
Author

Thanks for the advice. what do you mean by view tests for new views?

@KenanBek
Copy link
Member

Thanks for the advice. what do you mean by view tests for new views?

by views I mean Django views: Django Docs - Django Views

by view tests I mean tests for Django views: Django Docs - Testing our new view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants