Skip to content

Conversation

@Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Dec 29, 2021

Issues

Relates to #532 and #612

Proposed changes

Adapts some first changes required for the android integration but are not specific to it:

  • Add explicit overrides to TS codebase (code style)
  • Optimized Kotlin/C# generation to only generate virtual/open only when needed (code style and kotlin compilation perf)
  • Add strict JSON parsing for score (general runtime performance)
  • Improvement map type generation (Kotlin runtime performance)
  • Adapted some model properties to hold null when unused to avoid allocation of empty arrays (general memory performance)
  • Reworked linking of notes after serialization (cleaner data model)
  • Split code for serializer emitter to multiple files and adapted a string->ts.Node conversion approach where reasonable (code style)

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 added area-maintenance Overall code maintenance related platform-all Affects all platforms labels Dec 29, 2021
@Danielku15 Danielku15 self-assigned this Dec 29, 2021
@Danielku15 Danielku15 marked this pull request as ready for review December 29, 2021 23:05
@Danielku15 Danielku15 merged commit 21ede57 into develop Dec 29, 2021
@Danielku15 Danielku15 deleted the feature/android-foundation branch December 29, 2021 23:05
@Danielku15 Danielku15 mentioned this pull request Jan 9, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-maintenance Overall code maintenance related platform-all Affects all platforms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants