Skip to content

Ensure we don't interpret note symbols as section text #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Danielku15 merged 2 commits into from
Nov 28, 2021
Merged

Ensure we don't interpret note symbols as section text #685

Danielku15 merged 2 commits into from
Nov 28, 2021

Conversation

@Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Nov 28, 2021

Issues

Fixes #683

Proposed changes

Ignore note specific symbols when interpreting optional section text/marker combination in alphaTex

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Nov 28, 2021
@Danielku15 Danielku15 merged commit 4bfd120 into develop Nov 28, 2021
@Danielku15 Danielku15 deleted the feature/alphatex-section-rest branch November 28, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Danielku15 Danielku15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

alphaTex rest after section tag causes parsing error

2 participants

@Danielku15