Skip to content

Conversation

@Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Nov 4, 2021

Issues

Fixes #666

Proposed changes

  1. Adds detection on whether alphaTab is imported using ES6 modules and resolves the current script url accordingly
  2. Adds ES6 module compilation output for usage in ES6 modules within the browser and respective handling on the workers.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Nov 4, 2021
@Danielku15 Danielku15 marked this pull request as ready for review November 7, 2021 12:04
@Danielku15 Danielku15 merged commit bbcfb09 into develop Nov 7, 2021
@Danielku15 Danielku15 deleted the feature/es6-modules branch November 7, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Cannot read properties of null (reading 'src')" exception thrown when using alphaTab in Javascript module

2 participants