Skip to content

Conversation

@Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Jan 7, 2021

Issues

Fixes #355

Proposed changes

  1. Extends the layouting engine to register used Y-positions of given time positions. These positions are then considered in multi-voice scenarios to displace rests.
  2. Remove correction parameter of y-calculations
  3. Corrected improper/decentered placement of tab notes
  4. Adjusted beaming for tab bar renderer to handle overlaps and collisions better
  5. Ensure beam helpers for rests which fixes some tuplet issues.
  6. Adjusted some tuplet renderings.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Added handling of collisions for rests
  • Ensure more than 3 voices are placed properly
  • Allow rests to be placed in the middle of two other voices
  • Consider shifted rests in bar overflows
  • Merge rests of same duration at same location
  • Double check performance impact of new data caching
  • Avoid collisions on tab-beaming
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jan 7, 2021
@Danielku15 Danielku15 force-pushed the feature/multivoice-rest branch from 12fa316 to 9f3247a Compare January 7, 2021 22:57
@Danielku15 Danielku15 force-pushed the feature/multivoice-rest branch from 9f3247a to a1b652f Compare January 7, 2021 23:04
@Danielku15 Danielku15 force-pushed the feature/multivoice-rest branch from 812d317 to c521440 Compare January 9, 2021 22:15
@Danielku15 Danielku15 marked this pull request as ready for review January 9, 2021 22:42
@Danielku15 Danielku15 merged commit 625fabc into develop Jan 9, 2021
@Danielku15 Danielku15 deleted the feature/multivoice-rest branch January 9, 2021 22:45
This was referenced Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Second voice - collisions

2 participants