Skip to content

Improved detection of instrument and tuning in alphaTex #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Danielku15 merged 2 commits into from
Dec 31, 2020
Merged

Improved detection of instrument and tuning in alphaTex #484

Danielku15 merged 2 commits into from
Dec 31, 2020

Conversation

@Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Dec 31, 2020 •
edited
Loading

Issues

Fixes #449

Proposed changes

Adds an autodetection of the right tuning for a set of instruments.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Dec 31, 2020
@Danielku15 Danielku15 marked this pull request as ready for review December 31, 2020 01:53
@Danielku15 Danielku15 merged commit 9ae6706 into develop Dec 31, 2020
@Danielku15 Danielku15 deleted the feature/detect-tuning branch December 31, 2020 01:53
This was referenced Jan 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Danielku15 Danielku15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

alphatex tuning piano notation is higher than it should be

2 participants

@Danielku15