Skip to content

Conversation

@Danielku15
Copy link
Member

Issues

Relates to #2010
Preparation for #2247

Proposed changes

This PR reworks quite a significant bit of the bar renderers.

  1. Refactors the EffectBarRenderer into the other renderers. This way we can easier assume things about the renderers. Theoretically we could merge the BarRendererBase and LineBarRenderer. But currently this keep the logic a bit more separated.
  2. Additionally it significantly reworks how we calculate overflows.
  3. Various renderings and spacings have been optimized

This change overall changes quite a bit the alignments and paddings. Especially where overlaps where wrong or too generous, we are now more precise and compact. Overlaps also should reduce thanks to this.

The biggest impact had the bends and whammys as they have special handling regarding overlaps. They also now correctly reset and reserve sizes during wraps (including dynamic resizing).

The effect bands are still "top aligned" for now. But with this change we are prepared to optimize and rework the alignment.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Dec 5, 2025
@Danielku15 Danielku15 merged commit 09bb0ab into develop Dec 5, 2025
5 checks passed
@Danielku15 Danielku15 deleted the feature/effectbands branch December 5, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants