-
Notifications
You must be signed in to change notification settings - Fork 229
refactor(renderer): make effect bands part of main renderers #2414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Relates to #2010
Preparation for #2247
Proposed changes
This PR reworks quite a significant bit of the bar renderers.
EffectBarRendererinto the other renderers. This way we can easier assume things about the renderers. Theoretically we could merge theBarRendererBaseandLineBarRenderer. But currently this keep the logic a bit more separated.This change overall changes quite a bit the alignments and paddings. Especially where overlaps where wrong or too generous, we are now more precise and compact. Overlaps also should reduce thanks to this.
The biggest impact had the bends and whammys as they have special handling regarding overlaps. They also now correctly reset and reserve sizes during wraps (including dynamic resizing).
The effect bands are still "top aligned" for now. But with this change we are prepared to optimize and rework the alignment.
Checklist
Further details