Adds support for chords in MusicXML importer #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @Danielku15, could you please take a look at this PR? 😊 |
Danielku15
requested changes
Nov 29, 2023
Member
Danielku15
left a comment
Danielku15
left a comment
There was a problem hiding this comment.
Thanks for preparing this change and sorry for the delay. I currently have not much time to work on alphaTab.
Can you maybe also take care that the C# variant compiles?
Author
|
@Danielku15 I've addressed comments, take a look when you have time please |
Member
|
@coluzziandrea Thanks a lot for your contribution. I took care of the remaining updates and cross compilation bits. |
|
But after the update. the exported GP format file cannot be opened in Guitar Pro 8. When I try to open it, Guitar Pro 8 crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #667
Proposed changes
Checklist
Further details