A.H. and N.H. appearance using gp3 files

[nikolayrantsev]

Your environment

• Version used: master branch
• Platform used: JavaScript
• Rendering engine used: SVG
• Browser Name and Version: local env
• Operating System and version (desktop or mobile): MacOS 10.15.1 (19B88)
• Link to your project: local env

Expected Results

File should be rendered without added A.H. and N.H with pitch jumps and fractional fret values

Observed Results

A.H. symbols appear for the first notes in most of the bars (bars 1, 2,3, 4, etc)
N.H. appears with Hupper-Pull-Slide and breaks the prase (bars 6, 121). Moreover, jump in the pitch is coming with N.H. showing fractional fret value

Steps to Reproduce (for bugs)

1. Upload sample file
2. Observe A.H. and N.H. elements

Possible Solution

I've tried multiple gp3 files from widely available collections, this issue reproduces. I can't say what is the particular trigger, but for N.H. I see this with hummer-pull-slides.
When converter to .gp5 or .gpx file - issue disappears (but other minor things happen - not for this thread).
I've opened this .gp3 file in GuitarPro, Tux, MuseScore, GoPlayAlong, OpenSheetMusicDisplay, etc - there are harmonics there,
attached this file in gp3 format (the random sample from the first google result like "guitar tabs files collection free")

Metallica - Nothing Else Matters (3).gp3.zip

Please try to investigate. Thousands of songs are still in .gp3 format, not sure if a user will perform the conversion first somewhere, she just wants to upload and play!
Thanks again for the library - it's absolutely best

[Danielku15]

There was indeed an issue with reading GP3 files. It checked the note effect flags for harmonics while GP3 has the harmonics on the whole beat. Now it should be correct.

[nikolayrantsev]

Hi Daniel,
Thank you so much for the fix,
Works fine now