Triplets made of one quarter note and one eight note don't merge correctly

[cheap-glitch]

Your environment

• Version used: 0.9.3.173
• Platform used: JavaScript
• Rendering engine used: SVG
• Browser Name and Version: Firefox 65
• Operating System and version (desktop or mobile): Linux (desktop)
• Link to your project:

Expected Results

Triplets containing one quarter note and one eight note should merge together. Example in GP6:

Observed Results

Triplets made of one quarter note and one eight note don't merge correctly:

Steps to Reproduce (for bugs)

Create a tab with the following alphatex:

5.3.4{tu 3} 5.3.8{tu 3}

Possible Solution

[Danielku15]

I changed the tuplet grouping behavior in version 0.9.6.291. I cannot promise that the new logic really reflects the way it should be according to music theory. I could not find any good explanation in which precise scenarios a tuplet is considered "complete/full" and gets brackets.

I took Guitar Pro as reference but could not fully resemble its behavior. Anyhow most usual triplets which make sense from the theoretical definition. The default tuplets with equal durations behave correctly, and also various combinations on mixed duration tuplets seem to work now correctly.

If you have more examples which are not working, or more theoretical input on how tuplet groups should behave on mixed durations feel free to share the input 😉