Skip to content

Improvement: Transposing tabs with string adjustments.  #1587

@DevJett

Description

@DevJett

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I'm experiencing issues with the transposition feature not working as expected. When I set transpositionPitches: [-4], the notes incorrectly go below 0. Instead, they should move up a string rather than displaying a -1.

Steps to Reproduce:

  1. Open the attached guitar tab file with no transposition applied (see Screenshot 1).
  2. Set transpositionPitches to [-4].
  3. Observe the transposed guitar tab (see Screenshot 2).

Expected Behavior:
The notes should transpose correctly by moving up a string instead of displaying a negative value, as demonstrated in the expected output from Songsterr (see Screenshot 3).

Screenshots:

  1. No transposition applied:
    Screenshot 2024-07-17 at 14 26 35

  2. After Setting transpositionPitches to [-4]:
    Screenshot 2024-07-17 at 14 28 52

  3. Expected Transposition Output - Screenshot from Songsterr for the same tab:

Screenshot 2024-07-18 at 01 15 47

Expected Behavior

The notes should transpose correctly by moving up a string instead of displaying a negative value, as demonstrated in the expected output from Songsterr (see Screenshot 3 above).

Steps To Reproduce

  1. Download the GP File:

  2. Set the Transposition:

    • Open the downloaded file and set transpositionPitches to [-4].
  3. Observe the Issue:

    • You will notice that the notes incorrectly move below 0, displaying negative values.
  4. Compare with Songsterr:

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.4 (alpha)

Platform

Web

Environment

- **OS**:
- **Browser**:
- **.net Version**:

Anything else?

No response

Metadata

Metadata

Assignees

Labels

area-renderingEverything related to the renderingplatform-allAffects all platformsstate-acceptedThis is a valid topic to work on.

Projects

Status

Candidate

Relationships

None yet

Development

No branches or pull requests

Issue actions