Remove emitting the entry key with the METRICS_WRITE_ERROR metric (op…

…ensearch-project#71) Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
CoderJeffrey · Sep 21, 2021 · 43c0915 · 43c0915
1 parent cdcae41
commit 43c0915
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/org/opensearch/performanceanalyzer/metrics/PerformanceAnalyzerMetrics.java b/src/main/java/org/opensearch/performanceanalyzer/metrics/PerformanceAnalyzerMetrics.java
@@ -140,7 +140,7 @@ public static void addMetricEntry(StringBuilder value, String metricKey, long me
     private static void emitMetric(BlockingQueue<Event> q, Event entry) {
         if (!q.offer(entry)) {
             PerformanceAnalyzerApp.WRITER_METRICS_AGGREGATOR.updateStat(
-                    WriterMetrics.METRICS_WRITE_ERROR, entry.key, 1);
+                    WriterMetrics.METRICS_WRITE_ERROR, "", 1);
             LOG.debug("Could not enter metric {}", entry);
         }
     }

diff --git a/src/test/java/org/opensearch/performanceanalyzer/reader/MetricsEmitterTests.java b/src/test/java/org/opensearch/performanceanalyzer/reader/MetricsEmitterTests.java
@@ -356,7 +356,8 @@ public void testThreadNameCategorization() {
                 "search",
                 MetricsEmitter.categorizeThreadName("opensearch[I9AByra][search]", dimensions));
         assertEquals(
-                "write", MetricsEmitter.categorizeThreadName("opensearch[I9AByra][bulk]", dimensions));
+                "write",
+                MetricsEmitter.categorizeThreadName("opensearch[I9AByra][bulk]", dimensions));
         assertEquals("other", MetricsEmitter.categorizeThreadName("Top thread random", dimensions));
     }