Skip to content

Update 00-01-introduction.html grammatically #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2017

Conversation

DaricusDuncan
Copy link
Collaborator

Changed 'reglar' to 'regular'
Placed a comma after 'expressions'
Placed the comma after 'and' and placed after 'correct'

Changed 'reglar' to 'regular'
Placed a comma after 'expressions'
Placed the comma after 'and' and placed after 'correct'
@niccokunzmann niccokunzmann merged commit a8e27b5 into CoderDojoPotsdam:master May 27, 2017
@niccokunzmann
Copy link
Member

Thanks!

@DaricusDuncan
Copy link
Collaborator Author

@niccokunzmann Thank you so much for allowing me to help. I will continue to help support this because I really love the whole idea of this and I feel that I can learn and improve myself while helping you. I really did not know if I was doing the work correctly. I created a pull request after the fork I did and just crossed my fingers that everything was done the right way.

@niccokunzmann
Copy link
Member

@DaricusCodePath So you know, what I value at this pull-request:

  • It has a short description which sums up the change Update 00-01-introduction.html grammatically
  • You used the long description to describe the change in more detail
  • The checks run through, so I can be sure the content goes live immediately and not extra by me work is required.
    grafik
  • The pull-request and commit is a small, coherent change - all changes are summed up under "grammar" and I do not see where one correction could be useful without the other. Context: A commit can be reverted if it is not needed in the future. If a commit contains two changes of which one should be reverted but the other one should not be reverted, it can not be done by git or a click of a button but must be done by hand. To keep the git history understandable and managable, there should be those small, descriptive, coherent commits. Exampe: A commit named "Add feature X and Feature Y" can often be split into two commits.
  • With all these points satisfied, the form of this pull-request is more understandable to me than many of my commits.

@DaricusDuncan
Copy link
Collaborator Author

@niccokunzmann

Thank you so much for providing feedback and context on how pull requests work and benefit you. I will continue to provide detail and be thorough. I am really glad that you explained that it is ideally better to make multiple commits that are small are specific than one large commit that has parts that may not be needed.

I really appreciate all of the help. I am adjusting to all of this so you are really awesome for providing the feedback and everything. Thanks again as always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants