Skip to content

remove / from English button #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2017
Merged

remove / from English button #103

merged 1 commit into from
Aug 26, 2017

Conversation

niccokunzmann
Copy link
Member

On github pages, we do not serve fom "/" but from "/regex-tutorial/" so we need relative paths to work.
Fix: English path.

@alikahwaji Would you like to review and merge?

@niccokunzmann niccokunzmann merged commit f76f995 into master Aug 26, 2017
@niccokunzmann niccokunzmann deleted the niccokunzmann-patch-1 branch August 26, 2017 08:39
@weerox
Copy link
Contributor

weerox commented Aug 28, 2017

Can't we do absolute from /regex-tutorial/?

@niccokunzmann
Copy link
Member Author

niccokunzmann commented Aug 28, 2017

We can but then it does not work for a local build with jekyll serve

@weerox
Copy link
Contributor

weerox commented Aug 28, 2017

Oh, forgot about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants