Skip to content

Time Signature Change Functionality #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

SenDoesStuff
Copy link
Member

No description provided.

@NeeEoo NeeEoo force-pushed the Time-Signature-Changes branch from a345f91 to cc83f26 Compare October 17, 2024 22:34
@NeeEoo NeeEoo force-pushed the Time-Signature-Changes branch 2 times, most recently from 6beb58a to 2cde5bf Compare October 21, 2024 19:45
@NeeEoo NeeEoo added status:planned This is planned to happen status:accepted This has been solved successfully labels Jan 11, 2025
@Raltyro
Copy link
Contributor

Raltyro commented Jun 14, 2025

i still really need this

@Raltyro
Copy link
Contributor

Raltyro commented Jun 30, 2025

It's should be complete

@Raltyro
Copy link
Contributor

Raltyro commented Jun 30, 2025

oh yeah the one TODO in conductor is not really necessary

@SenDoesStuff SenDoesStuff marked this pull request as ready for review June 30, 2025 12:48
@Raltyro
Copy link
Contributor

Raltyro commented Jul 5, 2025

Proof of working examples

Time Signature Changes

third-sanctuary.mp4

Continuous Tempo Change

tacos-tirade.mp4

@Raltyro
Copy link
Contributor

Raltyro commented Jul 5, 2025

I'll upload the charts asap

@NexIsDumb
Copy link
Member

bro this shit is goated😭😭

@NexIsDumb
Copy link
Member

NexIsDumb commented Jul 5, 2025

altho i think that changing the text like that rapidly is creating ram shits (fuck you openfl text having to regenerate the graphics)
you can like see it in ur vid too ur ram increasing causing lil stutters

@Raltyro
Copy link
Contributor

Raltyro commented Jul 5, 2025

altho i think that changing the text like that rapidly is creating ram shits (fuck you openfl text having to regenerate the graphics) you can like see it in ur vid too ur ram increasing causing lil stutters

oh yeah thanks for pointing it out, im so sure it shouldnt cause any issue since i did set the fieldWidth so it doesnt have to regenerate to resize the graphic

also i have to be honest in the video i showed reason why is it uses 5.5/4 instead of 11/8 is because, the dances on characters gets faster because of beats being faster, i felt like that need to be fixed(?) but not in priority

@NexIsDumb
Copy link
Member

NexIsDumb commented Jul 5, 2025

i see, alrighty then, you have time anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted This has been solved successfully status:planned This is planned to happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants