Skip to content

Ground overlay: address PR comments #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 4, 2025
Merged

Ground overlay: address PR comments #16

merged 4 commits into from
Feb 4, 2025

Conversation

aednlaxer
Copy link
Collaborator

This PR addresses PR comments from 27.01.25

Not addressed comments:

  1. Possible copy/paste mistake - didn't fix it because not sure what the actual logic was supposed to be
  2. Moving call to avoid flickering - not clear what other PR is being discussed. Can we add a link to an flickering issue/PR discussion?
  3. Null check still in the method - addressed earlier by making parameter nullable

@aednlaxer aednlaxer requested a review from jokerttu February 3, 2025 07:59
@jokerttu jokerttu force-pushed the feat/google_maps_flutter_ground_overlay_support branch from 9f427b8 to cda9938 Compare February 4, 2025 13:57
@jokerttu jokerttu force-pushed the feat/google_maps_flutter_ground_overlay_support_fixes branch from 50ad5b7 to c502cb5 Compare February 4, 2025 13:58
@jokerttu jokerttu merged this pull request into feat/google_maps_flutter_ground_overlay_support Feb 4, 2025
1 check passed
@jokerttu jokerttu deleted the feat/google_maps_flutter_ground_overlay_support_fixes branch February 4, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokerttu jokerttu Awaiting requested review from jokerttu

Assignees
No one assigned
Labels
p: google_maps_flutter platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aednlaxer @jokerttu