Improve widget selection in the inspector (Related ticket: #3489) #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msavela
force-pushed
the
widget-selection-search
branch
from
964452c to
5009433
Compare
…#3489) * Add a method for finding a path from currently selected row item to the tree root (flutter#3489) * Add InspectorBreadcrumbNavigator (flutter#3489) * Set text style explicitly (flutter#3489) * Notify controller about selected widget on tap (flutter#3489) * Make currently selected item not clickable (flutter#3489) * Move breadcrumbs out of scrollable tree container (flutter#3489) * Tweak padding size and appearance parameters (flutter#3489) * Scroll to the end of the list so the last breadcrumb is always visible (flutter#3489) * Simplify constructor (flutter#3489) * Provide inspector tree controller directly to the tree widget where needed (flutter#3489) * Provide dummy inspectorTreeController to tests in inspector_tree_test (flutter#3489) * Ensure inspectorTreeController is provided when InspectorTree is showing a widget detail tree (flutter#3489) * Test if breadcrumbs widget is displayed (flutter#3489) * Remove empty constructor (flutter#3489) * Use row for showing breadcrumbs (flutter#3489)
Disable Details tree search & Highlight search matches with orange color & breadcrumbs
…instance_viewer_test.dart (flutter#3489)
# Conflicts: # packages/devtools_app/lib/src/common_widgets.dart # packages/devtools_app/lib/src/theme.dart # packages/devtools_app/lib/src/ui/search.dart
…ify path to the root calculation (flutter#3489)
# Conflicts: # packages/devtools_app/lib/src/common_widgets.dart # packages/devtools_app/lib/src/network/network_screen.dart # packages/devtools_app/test/goldens/timeline_flame_chart_with_selected_frame.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: