This repository was archived by the owner on Dec 11, 2023. It is now read-only.
Add support for updating existing courses in EloquentCourseRepository #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By trying to save an existing course with the previous version of `save`, an integrity exception was thrown. This could have been solved by telling Eloquent that the record already exists with `$model->exists = true;` but by doing so, we would break inserts. To fix the issue without having to write separated methods for **insert**s and **update**s, we used Eloquent's `updateOrCreate`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By trying to save an existing course with the previous version of
save, an integrity exception was thrown. This could have been solved by telling Eloquent that the record already exists with$model->exists = true;but by doing so, we would break inserts.To fix the issue without having to write separated methods for inserts and updates, we used Eloquent's
updateOrCreate.