Don't call setDimensions when widget has been disposed and BuildContext is null#31
Merged
rayliverified merged 1 commit intoCodelessly:masterfrom Nov 25, 2020
Merged
Conversation
Contributor
|
Thank you for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resuming the app from an external link on iOS only, didChangeMetrics is called which registers a postFrameCallback. Between the didChangeMetrics call and the frame completing the state is disposed causing an error to be thrown about the buildcontext being null. This allows setDimensions and setState to only be called if there is still a valid context meaning the widget is still in the tree. This fixes issue #29