Support trackpad scroll on Desktop platforms#183
Merged
rayliverified merged 1 commit intoCodelessly:masterfrom Aug 26, 2024
Merged
Support trackpad scroll on Desktop platforms#183rayliverified merged 1 commit intoCodelessly:masterfrom
rayliverified merged 1 commit intoCodelessly:masterfrom
Conversation
…getPlatform dragDevices as a baseline even if dragWithMouse enabled
Contributor
|
Awesome, thanks for the contribution! I'll take a look this week - Ray
…On Mon, Aug 5, 2024 at 10:48 AM Trefa1998 ***@***.***> wrote:
Refactored scroll_behavior.dart to add const constructors and use
TargetPlatform dragDevices as a baseline even if dragWithMouse enabled.
The methodology I used is one way of accomplishing this which I thought
made the most sense though it isn't necessarily the most immediately
obvious. The simpler solution would have been to just add the trackpad
device manually, but I think this approach covers the bases more
dynamically.
I'm happy to make any additional tweaks that may be desired to get this
merged (such as upping the version in the pubspec, which I haven't done in
case there was anything else that wanted to be added)
------------------------------
You can view, comment on, or merge this pull request online at:
#183
Commit Summary
- 6b72c3c
<6b72c3c>
Refactored scroll_behavior.dart to add const constructors and use
TargetPlatform dragDevices as a baseline even if dragWithMouse enabled
File Changes
(1 file <https://github.com/Codelessly/ResponsiveFramework/pull/183/files>
)
- *M* lib/src/utils/scroll_behavior.dart
<https://github.com/Codelessly/ResponsiveFramework/pull/183/files#diff-e0e84bdf729e8e0a5a02f652a36733317d1bb694963698ed9590cd9af02864b7>
(34)
Patch Links:
- https://github.com/Codelessly/ResponsiveFramework/pull/183.patch
- https://github.com/Codelessly/ResponsiveFramework/pull/183.diff
—
Reply to this email directly, view it on GitHub
<#183>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXZO3UJJUMDZQBQKOLDKW3ZP6NDFAVCNFSM6AAAAABMASHF5CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DQOBZGI2TEMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored scroll_behavior.dart to add const constructors and use TargetPlatform dragDevices as a baseline even if dragWithMouse enabled.
The methodology I used is one way of accomplishing this which I thought made the most sense though it isn't necessarily the most immediately obvious. The simpler solution would have been to just add the trackpad device manually, but I think this approach covers the bases more dynamically.
I'm happy to make any additional tweaks that may be desired to get this merged (such as upping the version in the pubspec, which I haven't done in case there was anything else that wanted to be added)