Feat: Display only the weights that are available for the selected font #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaicus
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
@arinaturcu This looks great! 🚀 I just found some stray variables 👀
After you remove those we can move this to QA so we can start testing.
Comment on lines
295
to
297
| $heading_font_family = get_theme_mod( 'neve_headings_font_family', '' ); | ||
| $body_font_family = get_theme_mod( 'neve_body_font_family', '' ); | ||
|
|
There was a problem hiding this comment.
I think we can remove these variables 🦭
|
Thank you for the review @abaicus 🚀 Yes, I forgot those variables 😅 Hope everything is good now. I will move this to the QA column. |
|
@arinaturcu Tested and didn't find any problem 🚀 Will move it to Ready to merge 👍 |
|
🎉 This PR is included in version 3.1.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When selecting the font weight, only the ones that are supported for the used font family are displayed.
Will affect visual aspect of the product
NO
Test instructions
The following controls should display the available weights for the selected body font family:
And the following for the heading font family:
The HFG components that use a font family selector should also be checked: menus, custom html, contact, and copyright.
Let me know if I missed any font-related control.
Closes #2631.