Skip to content

openFile: Fail correctly if the file doesn't exist #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Naktibalda merged 2 commits into from
Mar 14, 2022
Merged

openFile: Fail correctly if the file doesn't exist #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
486663a
openFile: Fail correctly if the file doesn't exist
Naktibalda Mar 14, 2022
214fe0c
Avoid double evaluation
Naktibalda Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/Codeception/Module/Filesystem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ public function _before(TestInterface $test): void
*/
public function amInPath(string $path): void
{
chdir($this->path = $this->absolutizePath($path) . DIRECTORY_SEPARATOR);
$this->path = $this->absolutizePath($path) . DIRECTORY_SEPARATOR;
if (!file_exists($this->path)) {
TestCase::fail('directory not found');
}
chdir($this->path);
$this->debug('Moved to ' . getcwd());
}

Expand Down Expand Up @@ -75,7 +79,11 @@ protected function absolutizePath(string $path): string
*/
public function openFile(string $filename): void
{
$this->file = file_get_contents($this->absolutizePath($filename));
$absolutePath = $this->absolutizePath($filename);
if (!file_exists($absolutePath)) {
TestCase::fail('file not found');
}
$this->file = file_get_contents($absolutePath);
$this->filePath = $filename;
}

Expand All @@ -89,11 +97,12 @@ public function openFile(string $filename): void
*/
public function deleteFile(string $filename): void
{
if (!file_exists($this->absolutizePath($filename))) {
$absolutePath = $this->absolutizePath($filename);
if (!file_exists($absolutePath)) {
TestCase::fail('file not found');
}

unlink($this->absolutizePath($filename));
unlink($absolutePath);
}

/**
Expand Down