Support HTML5 form attribute#1
Support HTML5 form attribute#1Naktibalda merged 7 commits intoCodeception:masterfrom SamMousa:patch-1
Conversation
Naktibalda
left a comment
Naktibalda
left a comment
There was a problem hiding this comment.
Thanks, could you implement a test for this feature?
Set up code coverage
|
Yes I will; but to get an idea of current test status I want to set up coverage first. Could you got to scrutinizer and add this repository? (I can set up the rest) |
|
Done! |
|
As it turns out, the current implementation is actually pretty broken. <html>
<body>
<form id="form1">
<a href="https://google.nl">
<button form="invalid" name="abc" >This will link</button>
</a>
<a href="https://google.nl">
<button name="abc" >This will submit</button>
</a>
</form>
<a href="https://google.nl">
<button form="form1" name="abcdef" >This will submit</button>
</a>
</body>
</html>From testing on chrome: The codeception implemention will always use an anchor if that is found first. I will rewrite the implementation of the button. |
|
Please review the code carefully. Note: I do not throw an error when a Note that an empty <form><a href="#"><button form="">Test</button></a></form> |
… type string, int given
3 participants
Fixes Codeception/Codeception#5477