Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covarpop #5340

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Covarpop #5340

wants to merge 8 commits into from

Conversation

MrShade138
Copy link

Description

Created a MySQL concept entry for the COVAR_POP function. I requested it to complete Codecademy's Github required content.

Issue Solved

Type of Change

  • Adding a new entry

Checklist

  • [ x] All writings are my own.
  • [ x] My entry follows the Codecademy Docs style guide.
  • [ x] My changes generate no new warnings.
  • [ x] I have performed a self-review of my own writing and code.
  • [ x] I have checked my entry and corrected any misspellings.
  • [ x] I have made corresponding changes to the documentation if needed.
  • [ x] I have confirmed my changes are not being pushed from my forked main branch.
  • [ x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [ x] I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Sep 27, 2024
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MrShade138 ,
I had a look at your file and it is not written in a proper docs standard format. I would like you to have a proper look at the documentation for docs. Please have a look at it and edit the entry accordingly.

Thanks,
Savi

@SaviDahegaonkar SaviDahegaonkar added the invalid This doesn't seem right; not eligible for Hacktoberfest label Sep 30, 2024
MrShade138 and others added 5 commits September 30, 2024 04:30
…Pop.md

Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
…Pop.md

Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
…Pop.md

Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Made updates suggested in PR 5340
Copy link
Author

@MrShade138 MrShade138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes have been completed

Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MrShade138 , I find that your PR does not follow proper documentation standards so I feel that we should close this PR and you can raise a new PR, for this issue and follows all the Codecademy docs standard

@@ -0,0 +1,47 @@
---
Title: 'MySQL: COVAR_POP() function'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Title: 'MySQL: COVAR_POP() function'
Title: 'MySQL: COVAR_POP() function'

According to the documentation standards, the file name should be the same as the title, but lowercase, with dashes instead of spaces, and all punctuation removed, and here the title name is different from the file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right; not eligible for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants