Fixed and enhanced ViewModel tests#175
Merged
christiannagel merged 10 commits intomainfrom Mar 20, 2024
Merged
Conversation
Removed viewmodel class member and moved it to the test cases.
Adapted test case for new vm. Enhanced assertions for that test case.
…adingNotificationAfterStart_ and adpated this test case for new vm.
…e simulated game.
christiannagel
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #174
Pull Request Summary
This pull request includes changes to the project, primarily focusing on updates to the project's target framework, package versions, and refactoring of the
GamePageViewModelTestsclass.Framework and Package Updates
The target framework of the project has been updated from .NET 7.0 to .NET 8.0, ensuring that the project is compatible with the latest features and improvements of the .NET platform. Additionally, the versions of the
xunit,xunit.runner.visualstudio, andcoverlet.collectorpackages have been updated, providing the project with the latest functionality and bug fixes from these packages.Refactoring of
GamePageViewModelTestsClassThe test cases were adapted for the new viemmodel.
The test cases were adapted in order to ensure they can run parallel without side effects.
Another test case for testing the game play has been added.