fix(Snackbar): fix snackbar positioning and responsiveness #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KRRISH96
added
design-update 🎨
rishichawda
reviewed
Dec 30, 2018
Contributor
rishichawda
left a comment
rishichawda
left a comment
There was a problem hiding this comment.
Can we have a close button on the indefinite snackbar? Like the one in material ui or similar? I think it would contribute more towards accessibility.
kaushiknishchay
suggested changes
Dec 31, 2018
kaushiknishchay
approved these changes
Dec 31, 2018
rishichawda
approved these changes
Jan 1, 2019
rishichawda
pushed a commit
to rishichawda/react-lite-ui
that referenced
this pull request
Jan 1, 2019
* fix(Snackbar): fix snackbar positioning and responsiveness * feat(Snackbar): Add close icon for indefinite snackbar Codebrahma#287 * docs(Snackbar): Update docs page * style(Snackbar): fix padding
Contributor
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status :
Ready
Description :
fix snackbar positions and responsiveness
Related Issues :
#287
Todos